WT-856 - Convert Other Buttons To Use Pretranslated Text#1469
Draft
dchukhin wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## WT-856-follow-up-snippets-filtered-by-locale #1469 +/- ##
================================================================================
+ Coverage 80.39% 80.62% +0.22%
================================================================================
Files 155 156 +1
Lines 10727 10879 +152
================================================================================
+ Hits 8624 8771 +147
- Misses 2103 2108 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…56-follow-up-pretranslated-label-for-all-button-blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Similar to #1449, this pull request updates all non-DownloadButton buttons to support pretranslated phrases.
Significant changes and points to review
Similar to #1250, this pull request updates all buttons:
labels into the button'scustom_labelfieldPretranslatedPhrase, so that Wagtail users can choose text that does not need to go to Smartling for translationIssue / Bugzilla link
discussion: #1250 (comment)
Testing
After running migrations, view any current page with buttons, and observe that they still appear the same as before in each language (no text should be lost in any language).
Note: this pull request assumes that all current non-downloadbutton buttons' text is custom (does not match "Get Firefox" or "Download Firefox"), but in the future, any button can choose from the pretranslated phrases.